Skip to content

Updated cloudstack go sdk to v2.17.1 #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sureshanaparti
Copy link

This PR updates cloudstack go sdk to v2.17.1.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the cloudstack Go SDK to v2.17.1 and bumps several indirect dependencies.

  • Update the cloudstack-go dependency from v2.16.1 to v2.17.1.
  • Remove the indirect dependency on testify and update other dependencies such as golang.org/x/mod and golang.org/x/tools.
  • Introduce go.uber.org/mock v0.5.0 as a new indirect dependency.
Comments suppressed due to low confidence (2)

go.mod:49

  • Removal of the indirect dependency on testify might affect the test infrastructure if tests rely on it. Verify that the test suite does not depend on testify or has been appropriately updated to use alternative libraries.
	github.com/rogpeppe/go-internal v1.11.0 // indirect

go.mod:54

  • Addition of go.uber.org/mock as an indirect dependency should be reviewed to ensure it integrates well with the existing testing framework, and that corresponding test mocks are updated accordingly.
	go.uber.org/mock v0.5.0 // indirect

@sureshanaparti sureshanaparti requested a review from vishesh92 July 1, 2025 07:06
Copy link
Collaborator

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

LGTM

  1. Enabled the global setting "enforce.post.requests.and.timestamps” to true

  2. Execute some API's like create volume /delete network API

  3. Monitor the network traffic via wireshark and we can see the POST request is enforced

Request Method POST

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants