Skip to content

Detail on changing primary storage scope added to adminguide and concepts #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 29, 2024

Conversation

abh1sar
Copy link
Contributor

@abh1sar abh1sar commented Apr 23, 2024

Documentation for Feature PR : apache/cloudstack#8875


📚 Documentation preview 📚: https://cloudstack-documentation--395.org.readthedocs.build/en/395/

Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weizhouapache
Copy link
Member

@abh1sar
can you add a screenshot of cluster->zone change ?

@abh1sar
Copy link
Contributor Author

abh1sar commented Apr 23, 2024

@abh1sar can you add a screenshot of cluster->zone change ?

@weizhouapache you mean the cluster->zone change scope form in the adminguide?

clusterToZone

@abh1sar
Copy link
Contributor Author

abh1sar commented Apr 23, 2024

@andrijapanicsb please review

@weizhouapache
Copy link
Member

@abh1sar can you add a screenshot of cluster->zone change ?

@weizhouapache you mean the cluster->zone change scope form in the adminguide?

clusterToZone

@abh1sar
looks good, can you add this image as well ?

@weizhouapache
Copy link
Member

@abh1sar
there are conflicts

@abh1sar
Copy link
Contributor Author

abh1sar commented Apr 23, 2024

@weizhouapache resolved conflicts and added Cluster->Zone UI screenshot

Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update this image if the dialog has changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, updated the image.

@andrijapanicsb
Copy link
Contributor

@blueorangutan docbuild

@blueorangutan
Copy link

@andrijapanicsb a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@andrijapanicsb
Copy link
Contributor

I don't see the other image, but I've asked BO to build docs again, and if both images are visible, I'm LGTM with the rest, nice explanation.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/395. (QA-JID 226)

@andrijapanicsb andrijapanicsb marked this pull request as ready for review April 24, 2024 13:36
@andrijapanicsb andrijapanicsb self-requested a review April 24, 2024 13:36
Copy link
Contributor

@andrijapanicsb andrijapanicsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Storage Pool, it cannot be disconnected from the hosts. In this case the Scope
change operation will error out. Such VMs need to be stopped or migrated first.

This feature is tested and supported for the following Hypervisor-Protocol-
Copy link
Contributor

@andrijapanicsb andrijapanicsb Apr 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This feature is tested and supported for the following Hypervisor-Protocol-
This feature is tested and supported for the following Hypervisor and storage combinations:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@andrijapanicsb
Copy link
Contributor

I made a few proposals to make it more readable from the end user (user doesn't necessarily care about "protocol" and "provider" - simply saying "KVM with NFS" is enough - again - just a proposal from my side, to simplify it.

@abh1sar
Copy link
Contributor Author

abh1sar commented Apr 24, 2024

@blueorangutan docbuild

@blueorangutan
Copy link

@abh1sar a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/395. (QA-JID 227)

@abh1sar
Copy link
Contributor Author

abh1sar commented May 1, 2024

@blueorangutan docbuild

@blueorangutan
Copy link

@abh1sar a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/395. (QA-JID 229)

@abh1sar
Copy link
Contributor Author

abh1sar commented May 22, 2024

@blueorangutan docbuild

@blueorangutan
Copy link

@abh1sar a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/395. (QA-JID 234)

@sureshanaparti sureshanaparti added this to the 4.19.1 milestone Jun 19, 2024
@abh1sar
Copy link
Contributor Author

abh1sar commented Jun 29, 2024

@blueorangutan docbuild

@blueorangutan
Copy link

@abh1sar a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/395. (QA-JID 237)

@sureshanaparti sureshanaparti merged commit 7f9b5d5 into apache:4.19 Jun 29, 2024
1 check passed
@abh1sar abh1sar deleted the scope-419 branch June 29, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants