Skip to content

Revert "Fix GCP auth step for GitHub Actions workflows" #34626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

damccorm
Copy link
Contributor

Reverts #34624

This didn't fix the underlying issue - https://github.com/apache/beam/actions/runs/14446457300/job/40508116220 and took us from flaky to permared

@damccorm
Copy link
Contributor Author

R: @Amar3tto

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@Amar3tto
Copy link
Collaborator

I am not sure that it took us from flaky to permared because many last runs were almost permared (~0-1 out of 16 green).

@damccorm
Copy link
Contributor Author

We were around 50% last week - https://github.com/apache/beam/actions/runs/14395319788 - it is interesting that it seems to be getting worse...

@Amar3tto
Copy link
Collaborator

I have an idea to add this command, it might help.

@damccorm
Copy link
Contributor Author

Sounds good, feel free to give it a try. Please use https://github.com/apache/beam/blob/master/.github/workflows/README.md#how-to-fix-workflows-for-committers to test on a branch in the repo, should allow validating changes before the PR stage

@Amar3tto
Copy link
Collaborator

Amar3tto commented Apr 15, 2025

Even the gcloud auth activate-service-account command gives the same error (Invalid JWT Signature).
What do you think if we will try to move to workload_identity_provider or Artifact Registry approach ?
Also, seems like gcr.io is deprecated.

@damccorm
Copy link
Contributor Author

@Amar3tto
Copy link
Collaborator

It was found that the secret needs to be updated.

@Amar3tto
Copy link
Collaborator

I think we can close this PR

@damccorm
Copy link
Contributor Author

Lets validate that the new approach works once the service account is updated first

@damccorm
Copy link
Contributor Author

Ok, confirmed working in https://github.com/apache/beam/actions/runs/14516646976

@damccorm damccorm closed this Apr 17, 2025
@damccorm damccorm deleted the revert-34624-fix-gcp-auth branch April 17, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants