-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Revert "Fix GCP auth step for GitHub Actions workflows" #34626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 7cb43f2.
R: @Amar3tto |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
I am not sure that it took us from flaky to permared because many last runs were almost permared (~0-1 out of 16 green). |
We were around 50% last week - https://github.com/apache/beam/actions/runs/14395319788 - it is interesting that it seems to be getting worse... |
Sounds good, feel free to give it a try. Please use https://github.com/apache/beam/blob/master/.github/workflows/README.md#how-to-fix-workflows-for-committers to test on a branch in the repo, should allow validating changes before the PR stage |
Even the |
I'm fine with that approach, could you try it out on a fork? We usually use https://console.cloud.google.com/iam-admin/serviceaccounts/details/107632624005655450554?e=13802955&invt=Abu0qQ&mods=dataflow_dev&project=apache-beam-testing |
It was found that the secret needs to be updated. |
I think we can close this PR |
Lets validate that the new approach works once the service account is updated first |
Ok, confirmed working in https://github.com/apache/beam/actions/runs/14516646976 |
Reverts #34624
This didn't fix the underlying issue - https://github.com/apache/beam/actions/runs/14446457300/job/40508116220 and took us from flaky to permared