Skip to content

AVRO-4000 Upgrade parent pom to 33 #2955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

slachiewicz
Copy link
Member

What is the purpose of the change

Upgrade Parent POM to accommodate plugin updates

Verifying this change

This change is a trivial cleanup without any test coverage.

Documentation

  • Does this pull request introduce a new feature? no

@github-actions github-actions bot added Java Pull Requests for Java binding build labels Jun 15, 2024
@jbonofre jbonofre self-requested a review June 28, 2024 05:05
@slachiewicz
Copy link
Member Author

I've reused properties from the parent and left overwrites in places where the previously used version was never than in the parent.
If we agree that downgrades are ok, I can remove a few more properties

@slachiewicz
Copy link
Member Author

Renaming properties were required in order to use dependency management from the parent.
I could keep old property names and then remap it from old to new - but this would make pom more verbose

@jbonofre
Copy link
Member

My point is that we can use the parent version without using the properties (directly implicit version from the parent). It's what we do in most of the Apache projects.

@slachiewicz slachiewicz changed the title AVRO-4000 Upgrade parent pom to 32 AVRO-4000 Upgrade parent pom to 33 Jul 28, 2024
@slachiewicz
Copy link
Member Author

I've updated to use our recently released Parent POM 33 and rebased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Java Pull Requests for Java binding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants