Skip to content

GH-46410: [C++] Add parquet options to Meson configuration #46647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

WillAyd
Copy link
Contributor

@WillAyd WillAyd commented May 30, 2025

Rationale for this change

This continues adding functionality to the Meson configuration

What changes are included in this PR?

This adds the parquet directory to the Meson configuration

Are these changes tested?

Yes

Are there any user-facing changes?

No

@WillAyd WillAyd requested a review from wgtmac as a code owner May 30, 2025 13:38
@WillAyd WillAyd added the CI: Extra Run extra CI label May 30, 2025
Copy link

⚠️ GitHub issue #46410 has been automatically assigned in GitHub to PR creator.

@@ -66,6 +66,22 @@ option(
type: 'string',
description: 'Arbitrary string that identifies the kind of package (for informational purposes)',
)
option('parquet', type: 'feature', description: 'Build the Parquet libraries')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few differences with the CMake configuration worth calling out.

First, CMake has an extra option for PARQUET_MINIMAL_DEPENDENCY. This seems to maybe not be used all of that often, so I did not bother implementing here. Let me know if that is a mistake.

CMake also requires that when either the executables or examples are built that you use static libraries. My assumption is that was done to make the CMake configuration easier, so I did not place that same restriction in the Meson configuration.

Finally, CMake will fail if a pre-installed version of OpenSSL is not found and encryption is required. This configuration is not as strict, and will use Meson's wrap system to resolve the OpenSSL dependency if it is not provided by the system

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels May 30, 2025
@WillAyd WillAyd force-pushed the meson-add-parquet branch from 45b61e8 to 840cc24 Compare June 6, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant