Skip to content

GH-46562: [GLib][CI] Enable ARROW_GLIB_WERROR by default #46563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

hiroyuki-sato
Copy link
Collaborator

@hiroyuki-sato hiroyuki-sato commented May 23, 2025

Rationale for this change

In GLib buiding, disabled -Werror compiler flag by default.

What changes are included in this PR?

Change -Werror by default. This change makes debugging easier.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

Copy link

⚠️ GitHub issue #46562 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting review Awaiting review label May 23, 2025
@kou kou changed the title GH-46562: [GLib][CI] Change enable ARROW_GLIB_WERROR by default GH-46562: [GLib][CI] Enable ARROW_GLIB_WERROR by default May 23, 2025
@hiroyuki-sato
Copy link
Collaborator Author

Oh, It seems that we need to fix many warnings before this flag change. Change to draft.

@hiroyuki-sato hiroyuki-sato marked this pull request as draft May 23, 2025 01:34
@hiroyuki-sato
Copy link
Collaborator Author

https://github.com/apache/arrow/actions/runs/15199666662/job/42751369386?pr=46563

--- stderr ---
arrow-glib/version.h:25: Error: Arrow: identifier not found on the first line:



^

arrow-glib/version.h:28: Warning: Arrow: "@section_id" parameter unexpected at this location:

 * @section_id: version-macros

 * @GARROW_S3_LOG_LEVEL_TRACE: Trace.

    ^

ccache: unknown option -- r


<unknown>:: Fatal: Arrow: warnings configured as fatal


<unknown>:: Fatal: Arrow: warnings configured as fatal







[69/123] Compiling C++ object gandiva-glib/libgandiva-glib-2100.dll.p/selection-vector.cpp.obj
[70/123] Compiling C++ object gandiva-glib/libgandiva-glib-2100.dll.p/projector.cpp.obj
[71/123] Compiling C++ object gandiva-glib/libgandiva-glib-2100.dll.p/node.cpp.obj
[72/123] Compiling C++ object parquet-glib/libparquet-glib-2100.dll.p/arrow-file-reader.cpp.obj
[73/123] Compiling C++ object parquet-glib/libparquet-glib-2100.dll.p/arrow-file-writer.cpp.obj
ninja: build stopped: subcommand failed.
Error: Process completed with exit code 1.

@hiroyuki-sato hiroyuki-sato force-pushed the topic/glib-build-enable-werror branch from 7e324b7 to 8420764 Compare May 24, 2025 13:46
@hiroyuki-sato
Copy link
Collaborator Author

We need to modify newline string on the Windows Platform.
We may need to modify this part

version_h = configure_file(
input: 'version.h.in',
output: 'version.h',
command: [
python3,
generate_version_header_py,
'--library',
'GARROW',
'--version',
version,
'--input',
'@INPUT@',
'--output',
'@OUTPUT@',
],
)

@hiroyuki-sato hiroyuki-sato force-pushed the topic/glib-build-enable-werror branch from 1eca642 to 305732e Compare May 29, 2025 11:26
@hiroyuki-sato hiroyuki-sato force-pushed the topic/glib-build-enable-werror branch from 305732e to 43eb26d Compare May 31, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant