Add TimeMilli and TimeMicro fields and conversions for the record API
#7544
+57
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
May 26, 2025
| @@ -602,6 +602,12 @@ pub enum Field { | |||
| /// Date without a time of day, stores the number of days from the | |||
| /// Unix epoch, 1 January 1970. | |||
| Date(i32), | |||
|
|
|||
| /// The total number of milliseconds since midnight. | |||
| TimeMillis(i32), | |||
There was a problem hiding this comment.
I think adding these new variants means this is an API change and thus must wait for our next breaking release (in July)
There was a problem hiding this comment.
That's fine, I expected as much.
What's the process here, do we just let this sit around till July? There doesn't seem to be a branch for stable (55) or the next major release (56)
There was a problem hiding this comment.
Yeah, we'll just leave the PR around until main opens for 56. That will probably be June sometime.
We could also potentially make a new branch to merge all the queued changes as well, but we haven't done that historically
alamb
added
next-major-release
alamb
changed the title
TimeMilli and TimeMicro fields and conversions for the record API
No worries |
etseidl
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
I recently wrote a PR for #7510 that was wrong. So this is rectifying that.
What changes are included in this PR?
I had used TimestampMillis for a time value that does not have a date, which is wrong.
I've added two new Fields for the missing concept of "time without date", and fixed the conversion to use them, and added the required trait implementations
Are there any user-facing changes?
There are new
Fieldvariants, so if people are matchingField, this'll cause a compile error when they upgrade