Skip to content

Introduce Time fields in record API, and resolve bug from #7510 #7543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
njaremko opened this issue May 23, 2025 · 0 comments · May be fixed by #7544
Open

Introduce Time fields in record API, and resolve bug from #7510 #7543

njaremko opened this issue May 23, 2025 · 0 comments · May be fixed by #7544
Labels

Comments

@njaremko
Copy link
Contributor

Describe the bug
I recently wrote a PR for #7510 that was wrong. So this is rectifying that.

I had used TimestampMillis for a time value that does not have a date, which is wrong.

I've added two new Fields for the missing concept of "time without date", and fixed the conversion to use them, and added the required trait implementations

To Reproduce
Try to parse a TIME_MILLIS parquet value using current main

Expected behavior
You get a field holding the number of milliseconds since midnight, but instead you'll get a field holding the number of milliseconds since epoch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant