Skip to content

Fix: Converted feature flight-sql-experimental to flight-sql #7546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix: Converted feature flight-sql-experimental to flight-sql #7546

wants to merge 4 commits into from

Conversation

kunalsinghdadhwal
Copy link

@kunalsinghdadhwal kunalsinghdadhwal commented May 24, 2025 •
edited by alamb
Loading

Which issue does this PR close?

Rationale for this change

Just some Cargo.toml changes

What changes are included in this PR?

Changed the flight-sql-experimental feature flag to flight-sql with backwards compatibility in arrow-flight

Are there any user-facing changes?

No

@github-actions github-actions bot added arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate labels May 24, 2025
@alamb
Copy link
Contributor

alamb commented May 25, 2025

Thank you for your contribution @kunalsinghdadhwal 🙏

I think there will be several other places in the code that need to be updated:

https://github.com/search?q=repo%3Aapache%2Farrow-rs%20flight-sql-experimental&type=code

Updating the README is also important:

arrow-rs/arrow-flight/README.md

Line 46 in 531370f

- `flight-sql-experimental`: Enables experimental support for

But all in all this looks good to me.

@kunalsinghdadhwal
Copy link
Author

kunalsinghdadhwal commented May 25, 2025 •
edited
Loading

will update the readme as well

@alamb Should i also change all the occurences of flight-sql-experimental in the codebase?

@alamb
Copy link
Contributor

alamb commented May 26, 2025

@alamb Should i also change all the occurences of flight-sql-experimental in the codebase?

Yes please

@kunalsinghdadhwal
Copy link
Author

Done

@alamb alamb mentioned this pull request May 27, 2025
Draft
alamb
alamb approved these changes May 27, 2025
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kunalsinghdadhwal -- this looks great to me

I made a follow on PR while this was on my mind to remove the old flag too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename flight-sql-experimental to flight-sql
2 participants
@kunalsinghdadhwal @alamb