Skip to content

Rename flight-sql-experimental to flight-sql #7498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alamb opened this issue May 13, 2025 · 1 comment · May be fixed by #7546
Open

Rename flight-sql-experimental to flight-sql #7498

alamb opened this issue May 13, 2025 · 1 comment · May be fixed by #7546
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@alamb
Copy link
Contributor

alamb commented May 13, 2025

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
The arrow-flight crate has a feature flag named flight-sql-experimental:

flight-sql-experimental = ["dep:arrow-arith", "dep:arrow-data", "dep:arrow-ord", "dep:arrow-row", "dep:arrow-select", "dep:arrow-string", "dep:once_cell", "dep:paste"]

However this feature has been used for several years now in several production systems. I think the experimental name is misleanding

Describe the solution you'd like

Remove the experimental from the flag name

Describe alternatives you've considered
To keep it backwards compatible, I recommend:

  1. Rename flight-sql-experimental to flight-sql
  2. Add a new flight-sql-experimental feature that just activates flight-sql with a comment to remove it after a while

Additional context

@alamb alamb added the enhancement Any new improvement worthy of a entry in the changelog label May 13, 2025
@kunalsinghdadhwal
Copy link

kunalsinghdadhwal commented May 24, 2025

@alamb Kindly review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants