Skip to content

feat(python/adbc_driver_manager): support more APIs sans PyArrow #2839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(python/adbc_driver_manager): support more APIs sans PyArrow #2839

wants to merge 2 commits into from

Conversation

lidavidm
Copy link
Member

Fixes #2827.

@lidavidm
Copy link
Member Author

This solves the main request of #2827 and could be extended for #2828. But I'd like to add more testing first here.

@lidavidm
Copy link
Member Author

I'm also curious if this approach to extensibility is "good enough". I haven't added anything that looks for entry points (to allow external packages to register more backends).

@paleolimbot
Copy link
Member

I'm also curious if this approach to extensibility is "good enough".

I think just getting the structure is great...registering stuff might just never come up.

@lidavidm lidavidm force-pushed the gh-2827 branch 3 times, most recently from f6a4dac to 68bcd06 Compare May 21, 2025 08:51
@lidavidm lidavidm marked this pull request as ready for review May 21, 2025 11:29
@lidavidm lidavidm requested a review from kou as a code owner May 21, 2025 11:29
@github-actions github-actions bot added this to the ADBC Libraries 19 milestone May 21, 2025
lidavidm
lidavidm commented May 21, 2025
View reviewed changes
python/adbc_driver_manager/tests/test_dbapi_polars_nopyarrow.py
Comment on lines +219 to +220
@pytest.mark.xfail(raises=dbapi.NotSupportedError)
def test_get_table_schema(sqlite: dbapi.Connection) -> None:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only because it seems polars can't currently import a schema by itself. I still need to go raise an issue/PR on their side

@lidavidm
Copy link
Member Author

@zeroshade would you be able to review?

@lidavidm lidavidm requested a review from zeroshade as a code owner June 16, 2025 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou Awaiting requested review from kou kou is a code owner

@zeroshade zeroshade Awaiting requested review from zeroshade zeroshade is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
ADBC Libraries 19
Development

Successfully merging this pull request may close these issues.

Feature Request: Don't require PyArrow for parameterized queries that use a Python sequence
2 participants
@lidavidm @paleolimbot