-
Notifications
You must be signed in to change notification settings - Fork 127
build(rust/driver/snowflake): include go source in package, add env override #2786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, in lieu of the symlink, I don't mind the old approach, so long as it can be overridden by the release script
Is there a reason you don't want the symlink? If we don't have a symlink we must either:
I think the package should be usable without doing anything special i.e. we should package the required source for the |
It may not be related to ADBC but... In general, UNIX style symlink doesn't work on Windows. For example, MSYS2 can't extract |
As long as we package the crate for publishing on linux it will work fine on systems that don't support symlinks. The files will be copied into the package:
|
Symlinks in source archive may have a problem when msys2/MINGW-packages#21803 is implemented. It's not related to Rust crates. We can solve it by resolving symlinks in release process like apache/arrow does. |
Closes #2783.
This adds a symlink to the go source to the Snowflake driver, which means cargo will include it in the package. This means the build script now works after packaging. This also adds support to override this with an env var (
ADBC_GO_SRC_DIR
).