-
Notifications
You must be signed in to change notification settings - Fork 15.1k
bug fix: DateTimeSensor can't render jinja template if use native obj #50744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Lee-W
merged 7 commits into
apache:main
from
nailo2c:bug-fix-render_template_native_obj_issue
May 27, 2025
Merged
bug fix: DateTimeSensor can't render jinja template if use native obj #50744
Lee-W
merged 7 commits into
apache:main
from
nailo2c:bug-fix-render_template_native_obj_issue
May 27, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lee-W
approved these changes
May 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few nits. In general, it looks good. I won't mind if someone wants to merge it directly
Lee-W
approved these changes
May 20, 2025
uranusjr
reviewed
May 26, 2025
providers/standard/src/airflow/providers/standard/sensors/date_time.py
Outdated
Show resolved
Hide resolved
For whatever it's worth, looks good to me. Thanks for addressing the issue! I can't wait to remove all those |
I'm so glad I could help with this issue 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #38336
🐞 Problem
This is quite an interesting case.
render_template_as_native_obj=True
, the Jinja expression is stored as a raw string whenDateTimeSensorAsync
is instantiated{{ (data_interval_end + macros.timedelta(minutes=1)) }}
→ falls through line 91 and is kept as‑is.pendulum.DateTime
object.When
execute()
callstimezone.parse
expects a string and raisesTypeError
.✅ Fix
_moment()
thatself.target_time
directly if it is already adatetime
/pendulum.DateTime
;timezone.parse
.timezone.parse(self.target_time)
with_moment()
.render_template_as_native_obj=False
.📝Example DAG (runs successfully after this patch)