Add audit log extra to table and improve UX #50100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbovenzi
requested review from
pierrejeambrun,
ryanahamilton,
jscheffl and
shubhamraj-git
as code owners
jscheffl
approved these changes
May 1, 2025
jscheffl
reviewed
May 1, 2025
2 tasks
|
nit: Should the copy button be there for the json? Seems a bit out of place? |
I thought about hiding it when the json is collapsed. wdyt? |
|
Yeah, I think that would look nicer. |
+1 - good to hide it when collapsed. Less clutter on the screen and you do not see what you copy anyway. Other than this... LGTM! |
hussein-awala
approved these changes
May 3, 2025
|
Merging and will update the json rendered input component in another PR |
mvfc
pushed a commit
to mvfc/airflow
that referenced
this pull request
May 6, 2025
* Add Audit Log events extra * Rearrange audit log columns for readability * Add expand/collapse all button for extra json
kaxil
pushed a commit
that referenced
this pull request
May 6, 2025
* Add Audit Log events extra * Rearrange audit log columns for readability * Add expand/collapse all button for extra json (cherry picked from commit b7b0daf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were missing the
extrafield on the Audit Log, which is fairly critical. Now we will try to see if it is valid json, if so, render it as such, with the option to expand/collapse the json field.Also, added a title to the page to reinforce that these are Audit Log Events.
Rearrange the columns to put any dag/run/task info at the end, because for many events they are blank.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.