-
Notifications
You must be signed in to change notification settings - Fork 15.1k
Add TIs tab to mapped task details #50085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
One question I have. Should the number in the tab should be the total count of mapped tasks or the rendered_map_index of the selected mapped TI? |
The map index is actually redundant to the breadcrumb. So actually you could remove it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Have you considered (as you are on this) to also support a direct "prev"/"next" navigation button, such that you don't need to click on the list to find the next but you can direct jump from 9 to 10?
e.g. like a < 9/32 >
?
Thats a good idea. I'd definitely like to add more quick nav options |
Playing around with the numbers wasn't great since map_index starts at 0, and we use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve +1
* Add TIs tab to mapped task details * Adjust Tab title to total mapped count
* Add TIs tab to mapped task details * Adjust Tab title to total mapped count (cherry picked from commit b11895d)
Add
Task Instances [{map_index}]
tab to a mapped task's detail page. This makes it easier to switch between mapped tasks to see logs, xcoms, etcCloses #34489
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in airflow-core/newsfragments.