Skip to content

Add TIs tab to mapped task details #50085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2025

Conversation

bbovenzi
Copy link
Contributor

@bbovenzi bbovenzi commented May 1, 2025

Add Task Instances [{map_index}] tab to a mapped task's detail page. This makes it easier to switch between mapped tasks to see logs, xcoms, etc

Closes #34489

Screenshot 2025-05-01 at 11 57 26 AM

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label May 1, 2025
@bbovenzi bbovenzi added this to the Airflow 3.0.1 milestone May 1, 2025
@bbovenzi
Copy link
Contributor Author

bbovenzi commented May 1, 2025

One question I have. Should the number in the tab should be the total count of mapped tasks or the rendered_map_index of the selected mapped TI?

@jscheffl
Copy link
Contributor

jscheffl commented May 1, 2025

One question I have. Should the number in the tab should be the total count of mapped tasks or the rendered_map_index of the selected mapped TI?

The map index is actually redundant to the breadcrumb. So actually you could remove it.
Alternative you can also display it as 9/32 so you have the total number and the individual index?

Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Have you considered (as you are on this) to also support a direct "prev"/"next" navigation button, such that you don't need to click on the list to find the next but you can direct jump from 9 to 10?
e.g. like a < 9/32 >?

@bbovenzi
Copy link
Contributor Author

bbovenzi commented May 2, 2025

Looks good.

Have you considered (as you are on this) to also support a direct "prev"/"next" navigation button, such that you don't need to click on the list to find the next but you can direct jump from 9 to 10? e.g. like a < 9/32 >?

Thats a good idea. I'd definitely like to add more quick nav options

@bbovenzi
Copy link
Contributor Author

bbovenzi commented May 2, 2025

Looks good.

Have you considered (as you are on this) to also support a direct "prev"/"next" navigation button, such that you don't need to click on the list to find the next but you can direct jump from 9 to 10? e.g. like a < 9/32 >?

Playing around with the numbers wasn't great since map_index starts at 0, and we use rendered_map_index in many places so we can't rely on it being a number. Instead, I am keeping the tab consistent with the total mapped TI count

Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve +1

@bbovenzi bbovenzi merged commit b11895d into apache:main May 2, 2025
42 checks passed
@bbovenzi bbovenzi deleted the add-TIs-tab-to-mapped-tasks branch May 2, 2025 21:25
mvfc pushed a commit to mvfc/airflow that referenced this pull request May 6, 2025
* Add TIs tab to mapped task details

* Adjust Tab title to total mapped count
kaxil pushed a commit that referenced this pull request May 6, 2025
* Add TIs tab to mapped task details

* Adjust Tab title to total mapped count

(cherry picked from commit b11895d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Counterintuitive functionality when viewing mapped TIs from Grid View
3 participants