Add auto refresh for HistoricalMetrics
#49830
Conversation
guan404ming
requested review from
bbovenzi,
pierrejeambrun,
ryanahamilton,
jscheffl and
shubhamraj-git
as code owners
guan404ming
force-pushed
the
refresh-historical-metric
branch
3 times, most recently
from
c5800af to
45a274f
Compare
There was a problem hiding this comment.
Overall looks good.
I'm wondering if this shouldn't always refresh. Autorefresh will stop when everything is settled, but won't update anymore if dagrun starts afterward... which is not great for a dashboard I think. Basically you can't leave that on a screen to monitor your cluster, things will stop refreshing after a while. (unless you'r very lucky and there's always a run ongoing.
airflow-core/src/airflow/ui/src/pages/Dashboard/HistoricalMetrics/HistoricalMetrics.tsx
Outdated
Show resolved
Hide resolved
guan404ming
force-pushed
the
refresh-historical-metric
branch
from
45a274f to
052e089
Compare
|
Ummmm The case makes sense to me. If we do want to monitor only when there are some pending task or dag, we need to do lots of trick (like auto-refresh until it has some run or something more tricky?) to perform the func that we want. I think how about just turn it back to auto-refresh for any condition? |
I think in this particular context it makes sense. On other pages, for instance DagRun details, once the DagRun is settled, there is no need to go further and keep refreshing, nothing will change. Here I think the use case is different on the overview page, that can be a long lasting page that will need to keep refreshing even if things are all settled for a while. |
guan404ming
force-pushed
the
refresh-historical-metric
branch
from
052e089 to
94e3958
Compare
guan404ming
force-pushed
the
refresh-historical-metric
branch
from
94e3958 to
ede8f46
Compare
Co-authored-by: pierrejeambrun <[email protected]>
guan404ming
force-pushed
the
refresh-historical-metric
branch
from
ede8f46 to
9fe66a0
Compare
pierrejeambrun
added
the
backport-to-v3-0-test
(cherry picked from commit cdf394b) Co-authored-by: Guan Ming(Wesley) Chiu <[email protected]> Co-authored-by: pierrejeambrun <[email protected]>
|
Thanks for the review and suggestion~ |
Backport successfully created: v3-0-test
|
(cherry picked from commit cdf394b) Co-authored-by: Guan Ming(Wesley) Chiu <[email protected]> Co-authored-by: pierrejeambrun <[email protected]>
Co-authored-by: pierrejeambrun <[email protected]>
Co-authored-by: pierrejeambrun <[email protected]>
Co-authored-by: pierrejeambrun <[email protected]>
guan404ming
changed the title
HistoricalMetricsHistoricalMetrics
Related Issue
closes: #49672
cc: @bbovenzi @tirkarthi
Why
HistoricalMetrics refresh will keep changing the last hour date
How
Auto-refresh them
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.