K8s test: Fix scheduler crash when using LocalExecutor #49677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason810496
added
area:dev-env
jason810496
changed the title
jason810496
requested review from
potiuk,
ashb and
gopidesupavan
as code owners
potiuk
approved these changes
Apr 24, 2025
potiuk
added
the
backport-to-v3-0-test
|
NICE! |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 24, 2025
…49677) (cherry picked from commit 2372dcd) Co-authored-by: LIU ZHE YOU <[email protected]>
Backport successfully created: v3-0-test
|
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Apr 24, 2025
…pache#49677) (cherry picked from commit 2372dcd) Co-authored-by: LIU ZHE YOU <[email protected]>
potiuk
pushed a commit
that referenced
this pull request
Apr 24, 2025
…49677) (#49718) (cherry picked from commit 2372dcd) Co-authored-by: LIU ZHE YOU <[email protected]>
kaxil
pushed a commit
that referenced
this pull request
Apr 24, 2025
(cherry picked from commit 2372dcd) Co-authored-by: LIU ZHE YOU <[email protected]>
|
Cool! Thanks for the fix! (I was looking into this a couple of weeks ago and could not find the root cause...) |
prabhusneha
pushed a commit
to astronomer/airflow
that referenced
this pull request
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #47518
related: #49101
Why
The root cause of scheduler crash when using
LocalExecutorhas been resolved, but not sure which PR really addressed the error. Now we can unblock the k8s test forLocalExecutor!What
We need to sightly refactor
ensure_deployment_healthtoensure_resource_health, sinceLocalExecutorusestatefulsetinstead ofdeploymentas k8s resource to run with.