test: k8s system tests speed-up active_deadline_seconds #48372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insomnes
changed the title
- Refactor for fail / success scenarios - Lower timer and remove second timer for fail scenario
insomnes
force-pushed
the
speed-up-k8s-ads-test
branch
from
d2b266c to
a3f2fb0
Compare
potiuk
approved these changes
Mar 27, 2025
|
Let's try |
pankajkoti
pushed a commit
to astronomer/airflow
that referenced
this pull request
Mar 28, 2025
…48372) - Refactor for fail / success scenarios - Lower timer and remove second timer for fail scenario
shubham-pyc
pushed a commit
to shubham-pyc/airflow
that referenced
this pull request
Apr 2, 2025
…48372) - Refactor for fail / success scenarios - Lower timer and remove second timer for fail scenario
nailo2c
pushed a commit
to nailo2c/airflow
that referenced
this pull request
Apr 4, 2025
…48372) - Refactor for fail / success scenarios - Lower timer and remove second timer for fail scenario
simonprydden
pushed a commit
to simonprydden/airflow
that referenced
this pull request
Apr 8, 2025
…48372) - Refactor for fail / success scenarios - Lower timer and remove second timer for fail scenario
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changed test is one of the slowest in the
kubernetes_testssuite. It was added in:#33379
We don't need to test the setting in question twice with different values for the fail scenario, phase and reason are reliable markers to check if the pod was killed because of the
active_deadline_seconds. For the same reason we don't need that long value for this test. Instead, I've decided to introduce a non-failing scenario to check that the long value of the setting works as expected.These changes speed up the summary time for two calls from 70 - 90 seconds to 20-35 seconds.
It was discovered and discussed during work on #47939
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.