-
Notifications
You must be signed in to change notification settings - Fork 15.2k
test: k8s set [api/base_url] with Helm in Breeze #48040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f4ac6e3
to
09e5c5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! Only one small nit.
be62579
to
d8f8bd9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, the k8s tests work well !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NICE!
d8f8bd9
to
9a4db6f
Compare
Wasn't a good moment for rebase, will try to catch on fixes later today |
Removing setup par in base k8s test class which runs rollout restart on deployment for the kubernetes host setup
- make get_kubernetes_port_numbers "public" - warning in _get_kind_cluster_config_content in case of non-existing file - remove previous help function
9a4db6f
to
7e960f8
Compare
* test: k8s set [api/base_url] with Helm in Breeze Removing setup par in base k8s test class which runs rollout restart on deployment for the kubernetes host setup * refactor: extract api host + port getting to function * test: delete overlooked method _parse_airflow_cfg_dict_as_escaped_toml * feat: use get_kubernetes_port_numbers for cluster port detection - make get_kubernetes_port_numbers "public" - warning in _get_kind_cluster_config_content in case of non-existing file - remove previous help function
* test: k8s set [api/base_url] with Helm in Breeze Removing setup par in base k8s test class which runs rollout restart on deployment for the kubernetes host setup * refactor: extract api host + port getting to function * test: delete overlooked method _parse_airflow_cfg_dict_as_escaped_toml * feat: use get_kubernetes_port_numbers for cluster port detection - make get_kubernetes_port_numbers "public" - warning in _get_kind_cluster_config_content in case of non-existing file - remove previous help function
* test: k8s set [api/base_url] with Helm in Breeze Removing setup par in base k8s test class which runs rollout restart on deployment for the kubernetes host setup * refactor: extract api host + port getting to function * test: delete overlooked method _parse_airflow_cfg_dict_as_escaped_toml * feat: use get_kubernetes_port_numbers for cluster port detection - make get_kubernetes_port_numbers "public" - warning in _get_kind_cluster_config_content in case of non-existing file - remove previous help function
* test: k8s set [api/base_url] with Helm in Breeze Removing setup par in base k8s test class which runs rollout restart on deployment for the kubernetes host setup * refactor: extract api host + port getting to function * test: delete overlooked method _parse_airflow_cfg_dict_as_escaped_toml * feat: use get_kubernetes_port_numbers for cluster port detection - make get_kubernetes_port_numbers "public" - warning in _get_kind_cluster_config_content in case of non-existing file - remove previous help function
[api/base_url]
via parameter from helm chartcloses: #47939
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.