Skip to content

test: k8s set [api/base_url] with Helm in Breeze #48040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 25, 2025

Conversation

insomnes
Copy link
Contributor

@insomnes insomnes commented Mar 20, 2025

  • Removing setup part in base k8s test class which runs rollout restart on deployment for the kubernetes host setup and related methods
  • Set the [api/base_url] via parameter from helm chart

closes: #47939


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@insomnes insomnes marked this pull request as draft March 20, 2025 23:29
@insomnes insomnes changed the title [WIP] test: k8s set [api/base_url] with Helm in Breeze test: k8s set [api/base_url] with Helm in Breeze Mar 20, 2025
@insomnes insomnes marked this pull request as ready for review March 20, 2025 23:51
@insomnes insomnes force-pushed the k8s-set-api-base-url-conf branch from f4ac6e3 to 09e5c5c Compare March 21, 2025 06:01
@jason810496 jason810496 added the full tests needed We need to run full set of tests for this PR to merge label Mar 21, 2025
@jason810496 jason810496 reopened this Mar 21, 2025
Copy link
Member

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Only one small nit.

@insomnes insomnes force-pushed the k8s-set-api-base-url-conf branch 4 times, most recently from be62579 to d8f8bd9 Compare March 22, 2025 22:33
Copy link
Member

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the k8s tests work well !

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE!

@insomnes insomnes force-pushed the k8s-set-api-base-url-conf branch from d8f8bd9 to 9a4db6f Compare March 24, 2025 08:24
@insomnes insomnes requested a review from gopidesupavan as a code owner March 24, 2025 08:24
@insomnes
Copy link
Contributor Author

Wasn't a good moment for rebase, will try to catch on fixes later today

Removing setup par in base k8s test class which runs rollout restart on
deployment for the kubernetes host setup
- make get_kubernetes_port_numbers "public"
- warning in _get_kind_cluster_config_content in case of non-existing file
- remove previous help function
@insomnes insomnes force-pushed the k8s-set-api-base-url-conf branch from 9a4db6f to 7e960f8 Compare March 25, 2025 09:45
@jason810496 jason810496 merged commit 86d5285 into apache:main Mar 25, 2025
89 checks passed
abhishekbhakat pushed a commit to abhishekbhakat/my_airflow that referenced this pull request Mar 25, 2025
* test: k8s set [api/base_url] with Helm in Breeze

Removing setup par in base k8s test class which runs rollout restart on
deployment for the kubernetes host setup

* refactor: extract api host + port getting to function

* test: delete overlooked method _parse_airflow_cfg_dict_as_escaped_toml

* feat: use get_kubernetes_port_numbers for cluster port detection

- make get_kubernetes_port_numbers "public"
- warning in _get_kind_cluster_config_content in case of non-existing file
- remove previous help function
@insomnes insomnes deleted the k8s-set-api-base-url-conf branch March 25, 2025 12:26
pankajkoti pushed a commit to astronomer/airflow that referenced this pull request Mar 28, 2025
* test: k8s set [api/base_url] with Helm in Breeze

Removing setup par in base k8s test class which runs rollout restart on
deployment for the kubernetes host setup

* refactor: extract api host + port getting to function

* test: delete overlooked method _parse_airflow_cfg_dict_as_escaped_toml

* feat: use get_kubernetes_port_numbers for cluster port detection

- make get_kubernetes_port_numbers "public"
- warning in _get_kind_cluster_config_content in case of non-existing file
- remove previous help function
shubham-pyc pushed a commit to shubham-pyc/airflow that referenced this pull request Apr 2, 2025
* test: k8s set [api/base_url] with Helm in Breeze

Removing setup par in base k8s test class which runs rollout restart on
deployment for the kubernetes host setup

* refactor: extract api host + port getting to function

* test: delete overlooked method _parse_airflow_cfg_dict_as_escaped_toml

* feat: use get_kubernetes_port_numbers for cluster port detection

- make get_kubernetes_port_numbers "public"
- warning in _get_kind_cluster_config_content in case of non-existing file
- remove previous help function
nailo2c pushed a commit to nailo2c/airflow that referenced this pull request Apr 4, 2025
* test: k8s set [api/base_url] with Helm in Breeze

Removing setup par in base k8s test class which runs rollout restart on
deployment for the kubernetes host setup

* refactor: extract api host + port getting to function

* test: delete overlooked method _parse_airflow_cfg_dict_as_escaped_toml

* feat: use get_kubernetes_port_numbers for cluster port detection

- make get_kubernetes_port_numbers "public"
- warning in _get_kind_cluster_config_content in case of non-existing file
- remove previous help function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

K8S Test: Set [api/base_url] with Helm in Breeze
3 participants