Skip to content

Switch to latest "stash" action from apache/infrastructure-actions #45653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jan 14, 2025

There are a few improvements just merged in the latest version of the "stash" suite of actions that we contributed.

Most of the changes were result of making the #45289 works with stash action and since the changes were added we found that we need to do things differently (for example rather than storing .cache directly we need to tar the directories because we need to preserve permissions and symbolic links). There is however one useful feature that remained - namely protecting against accidentally downloading stash from the main branch, when the PR needs only "its own" artifact (helpful in case of typos in the workflow where wrong image artifact name is specified).

This PR switches to latest version of the action and enables the protection in "prepare images" composite actions.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

There are a few improvements just merged in the latest version
of the "stash" suite of actions that we contributed.

Most of the changes were result of making the apache#45289 works with
stash action and since the changes were added we found that we
need to do things differently (for example rather than storing
.cache directly we need to tar the directories because we need
to preserve permissions and symbolic links). There is however
one useful feature that remained - namely protecting against
accidentally downloading stash from the main branch, when the
PR needs only "its own" artifact (helpful in case of typos in the
workflow where wrong image artifact name is specified).

This PR switches to latest version of the action and enables the
protection in "prepare images" composite actions.
@potiuk
Copy link
Member Author

potiuk commented Jan 14, 2025

cc: @assignUser

@potiuk potiuk merged commit 68cdae6 into apache:main Jan 14, 2025
86 of 87 checks passed
@potiuk potiuk deleted the switched-to-latest-stash branch January 14, 2025 19:24
@gopidesupavan
Copy link
Member

Nice :)

HariGS-DB pushed a commit to HariGS-DB/airflow that referenced this pull request Jan 16, 2025
…pache#45653)

There are a few improvements just merged in the latest version
of the "stash" suite of actions that we contributed.

Most of the changes were result of making the apache#45289 works with
stash action and since the changes were added we found that we
need to do things differently (for example rather than storing
.cache directly we need to tar the directories because we need
to preserve permissions and symbolic links). There is however
one useful feature that remained - namely protecting against
accidentally downloading stash from the main branch, when the
PR needs only "its own" artifact (helpful in case of typos in the
workflow where wrong image artifact name is specified).

This PR switches to latest version of the action and enables the
protection in "prepare images" composite actions.
dauinh pushed a commit to dauinh/airflow that referenced this pull request Jan 24, 2025
…pache#45653)

There are a few improvements just merged in the latest version
of the "stash" suite of actions that we contributed.

Most of the changes were result of making the apache#45289 works with
stash action and since the changes were added we found that we
need to do things differently (for example rather than storing
.cache directly we need to tar the directories because we need
to preserve permissions and symbolic links). There is however
one useful feature that remained - namely protecting against
accidentally downloading stash from the main branch, when the
PR needs only "its own" artifact (helpful in case of typos in the
workflow where wrong image artifact name is specified).

This PR switches to latest version of the action and enables the
protection in "prepare images" composite actions.
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
…pache#45653)

There are a few improvements just merged in the latest version
of the "stash" suite of actions that we contributed.

Most of the changes were result of making the apache#45289 works with
stash action and since the changes were added we found that we
need to do things differently (for example rather than storing
.cache directly we need to tar the directories because we need
to preserve permissions and symbolic links). There is however
one useful feature that remained - namely protecting against
accidentally downloading stash from the main branch, when the
PR needs only "its own" artifact (helpful in case of typos in the
workflow where wrong image artifact name is specified).

This PR switches to latest version of the action and enables the
protection in "prepare images" composite actions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants