Apply zizmor findings #45408
Merged
Apply zizmor findings #45408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gopidesupavan
requested review from
potiuk,
ashb and
jedcunningham
as code owners
|
going to run for all combinations just to make sure syntax are working :) |
gopidesupavan
added
canary
gopidesupavan
requested review from
kaxil,
hussein-awala,
romsharon98,
amoghrajesh,
eladkal,
shahar1 and
jscheffl
potiuk
reviewed
Jan 5, 2025
potiuk
reviewed
Jan 5, 2025
potiuk
reviewed
Jan 5, 2025
potiuk
reviewed
Jan 5, 2025
|
Oops will update all the quotes :) |
potiuk
reviewed
Jan 5, 2025
potiuk
reviewed
Jan 5, 2025
potiuk
reviewed
Jan 5, 2025
Indeed :) |
HariGS-DB
pushed a commit
to HariGS-DB/airflow
that referenced
this pull request
Jan 16, 2025
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
Xuanwo
pushed a commit
to apache/iceberg-rust
that referenced
this pull request
Mar 24, 2025
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> this patch make ci more safety using static check zizmor: to avoid code injection more: - apache/airflow#45408 - astral-sh/ruff#14844 and github actions safety is more and more important: link: https://www.stepsecurity.io/blog/harden-runner-detection-tj-actions-changed-files-action-is-compromised Signed-off-by: yihong0618 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have nice tool available to find issues in github workflows/actions files.
https://woodruffw.github.io/zizmor/
Thanks to zizmor and @assignUser for sharing the details
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.