-
Notifications
You must be signed in to change notification settings - Fork 15.2k
Fix updating variables during variable imports #33932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ephraimbuddy
merged 6 commits into
apache:main
from
astronomer:dont-override-variables-during-import
Sep 1, 2023
Merged
Fix updating variables during variable imports #33932
ephraimbuddy
merged 6 commits into
apache:main
from
astronomer:dont-override-variables-during-import
Sep 1, 2023
+129
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
reviewed
Aug 31, 2023
uranusjr
reviewed
Aug 31, 2023
uranusjr
reviewed
Aug 31, 2023
I think we should a flag specifying that behaviour. I think the flag should be something of (probably too long name):
IMHO override shoudl remain as it is (default), as it could break existing usages. |
2738fc5
to
2718f6f
Compare
2718f6f
to
7c6080b
Compare
potiuk
approved these changes
Aug 31, 2023
uranusjr
reviewed
Sep 1, 2023
uranusjr
reviewed
Sep 1, 2023
7c6080b
to
161e822
Compare
uranusjr
reviewed
Sep 1, 2023
uranusjr
reviewed
Sep 1, 2023
We should only create new variables during variable imports and not update already existing variables.
Co-authored-by: Tzu-ping Chung <[email protected]>
Co-authored-by: Tzu-ping Chung <[email protected]>
3e29b65
to
91fd57d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should only create new variables during variable imports and not update already existing variables.