Make cluster_context templated in KubernetesPodOperator #33604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
Taragolis
approved these changes
Aug 22, 2023
hussein-awala
approved these changes
Aug 22, 2023
hussein-awala
changed the title
This was referenced Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following Airflow's best practice guide for Variables, I have tried replacing all of my variables' usage in
KubernetesPodOperator, such asimage,config_fileetc.. to use the templated syntax. However, forcluster_contextthis didn't work since it's not templated, as in the example below:default_args = { - 'cluster_context': Variable.get('k8s_cluster_name') + 'cluster_context': '{{ var.value.k8s_cluster_name }}' }I'd love to have this small feature incorporated, let me know of anything required beyond this commit