Skip to content

Add local_infile parameter to S3ToMySqlOperator #33459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 17, 2023

Conversation

benchoncy
Copy link
Contributor

Adding local_infile option to MySQL providers S3ToMySqlOperator transfer, similar to bulk_upload flag on VerticaToMySqlOperator.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Aug 16, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@benchoncy benchoncy changed the title Mysql provider transfer hook kwargs MySQL provider transfer S3ToMySqlOperator add local_infile option Aug 16, 2023
@Lee-W
Copy link
Member

Lee-W commented Aug 17, 2023

@hussein-awala Looks like the static check failure does not relate to this PR. Should we rerun the CI?

@vincbeck
Copy link
Contributor

@hussein-awala Looks like the static check failure does not relate to this PR. Should we rerun the CI?

Just did

@vincbeck vincbeck changed the title MySQL provider transfer S3ToMySqlOperator add local_infile option MySQL provider transfer S3ToMySqlOperator add local_infile option Aug 17, 2023
@eladkal eladkal changed the title MySQL provider transfer S3ToMySqlOperator add local_infile option Add local_infile parameter to S3ToMySqlOperator Aug 17, 2023
@vincbeck vincbeck merged commit 744aa60 into apache:main Aug 17, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 17, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@benchoncy benchoncy deleted the mysql-provider-transfer-hook-kwargs branch August 17, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants