Skip to content

feat(providers/microsoft): add DefaultAzureCredential support to cosmos #33436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented Aug 16, 2023

  • add DefaultAzureCredential support to cosmos
    • use CosmosDBManagementClient to authenticate cosmos client through DefaultAzureCredential

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@Lee-W Lee-W force-pushed the add-DefaultAzureCredential-support-to-cosmos branch 3 times, most recently from 4bee565 to 09a6bd1 Compare August 23, 2023 02:58
@Lee-W Lee-W marked this pull request as ready for review August 23, 2023 02:59
@Lee-W Lee-W force-pushed the add-DefaultAzureCredential-support-to-cosmos branch 2 times, most recently from 2ce0b49 to 1663f76 Compare August 23, 2023 14:59
@Lee-W Lee-W force-pushed the add-DefaultAzureCredential-support-to-cosmos branch from 1663f76 to 02cf98c Compare August 25, 2023 04:09
@Lee-W Lee-W requested a review from phanikumv August 25, 2023 16:42
@Lee-W
Copy link
Member Author

Lee-W commented Aug 26, 2023

I notice the constrains keep failing. Is there anything I need to change for it?

@potiuk
Copy link
Member

potiuk commented Aug 26, 2023

I notice the constrains keep failing. Is there anything I need to change for it?

Fix for it in #33774 -> they also fail in main and the reason is that we already relaxed the limit for hive provider for 3.11 but we have not released the matching version of hive provider yet in PyPI (we just made it possible back for the hive provider to work on 3.11 but it needs releasing a new provider version due to dependency changes required for 3.11).

The #33774 will skip over hive provider for 3.11 temporarily and we will remove it when we have the new hive provider

@potiuk
Copy link
Member

potiuk commented Aug 26, 2023

We can merge it now even with failing constrainst (they also fail in main).

@potiuk potiuk merged commit 03529d5 into apache:main Aug 26, 2023
@Lee-W
Copy link
Member Author

Lee-W commented Aug 26, 2023

I notice the constrains keep failing. Is there anything I need to change for it?

Fix for it in #33774 -> they also fail in main and the reason is that we already relaxed the limit for hive provider for 3.11 but we have not released the matching version of hive provider yet in PyPI (we just made it possible back for the hive provider to work on 3.11 but it needs releasing a new provider version due to dependency changes required for 3.11).

The #33774 will skip over hive provider for 3.11 temporarily and we will remove it when we have the new hive provider

Thanks for the detail explaining 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants