-
Notifications
You must be signed in to change notification settings - Fork 15.1k
Add sql_hook_params
parameter to SqlToS3Operator
#33425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e904703
to
9903043
Compare
9903043
to
0ab1663
Compare
FYI, I added a test to |
Because you changed how the BaseHook is accessed and it breaks the mock. |
0ab1663
to
c356333
Compare
c356333
to
dc943c0
Compare
Adding `sql_hook_params` parameter to `SqlToS3Operator`. This will allow you to pass extra config params to the underlying SQL hook. This uses the same "sql_hook_params" parameter name as already used in `SqlToSlackOperator`.
dc943c0
to
f3f71ff
Compare
I have now split the |
sql_hook_params
parameter to SqlToS3Operator
Adding `sql_hook_params` parameter to `SqlToS3Operator`. This will allow you to pass extra config params to the underlying SQL hook.
Adding
sql_hook_params
parameter toSqlToS3Operator
. This will allow you to pass extra config params to the underlying SQL hook.This uses the same parameter name, "sql_hook_params", as already used in
SqlToSlackOperator
.(This is related to #33427 which adds
sql_hook_params
to the opposite transfer,S3ToSqlOperator
, however that one needed a different approach by usingBaseHook.get_hook
instead ofConnection.get_hook
)^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.