Skip to content

openlineage: defensively check for provided datetimes in listener #33343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2023
Merged

openlineage: defensively check for provided datetimes in listener #33343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions airflow/providers/openlineage/plugins/adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,8 @@ def start_task(
parent_job_name: str | None,
parent_run_id: str | None,
code_location: str | None,
nominal_start_time: str,
nominal_end_time: str,
nominal_start_time: str | None,
nominal_end_time: str | None,
owners: list[str],
task: OperatorLineage | None,
run_facets: dict[str, BaseFacet] | None = None, # Custom run facets
Expand Down
28 changes: 21 additions & 7 deletions airflow/providers/openlineage/plugins/listener.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

import logging
from concurrent.futures import Executor, ThreadPoolExecutor
from datetime import datetime
from typing import TYPE_CHECKING

from airflow.listeners import hookimpl
Expand Down Expand Up @@ -76,16 +77,22 @@ def on_running():

task_metadata = self.extractor_manager.extract_metadata(dagrun, task)

start_date = task_instance.start_date if task_instance.start_date else datetime.now()
data_interval_start = (
dagrun.data_interval_start.isoformat() if dagrun.data_interval_start else None
)
data_interval_end = dagrun.data_interval_end.isoformat() if dagrun.data_interval_end else None

self.adapter.start_task(
run_id=task_uuid,
job_name=get_job_name(task),
job_description=dag.description,
event_time=task_instance.start_date.isoformat(),
event_time=start_date.isoformat(),
parent_job_name=dag.dag_id,
parent_run_id=parent_run_id,
code_location=None,
nominal_start_time=dagrun.data_interval_start.isoformat(),
nominal_end_time=dagrun.data_interval_end.isoformat(),
nominal_start_time=data_interval_start,
nominal_end_time=data_interval_end,
owners=dag.owner.split(", "),
task=task_metadata,
run_facets={
Expand Down Expand Up @@ -113,10 +120,13 @@ def on_success():
task_metadata = self.extractor_manager.extract_metadata(
dagrun, task, complete=True, task_instance=task_instance
)

end_date = task_instance.end_date if task_instance.end_date else datetime.now()

self.adapter.complete_task(
run_id=task_uuid,
job_name=get_job_name(task),
end_time=task_instance.end_date.isoformat(),
end_time=end_date.isoformat(),
task=task_metadata,
)

Expand All @@ -139,10 +149,12 @@ def on_failure():
dagrun, task, complete=True, task_instance=task_instance
)

end_date = task_instance.end_date if task_instance.end_date else datetime.now()

self.adapter.fail_task(
run_id=task_uuid,
job_name=get_job_name(task),
end_time=task_instance.end_date.isoformat(),
end_time=end_date.isoformat(),
task=task_metadata,
)

Expand All @@ -165,12 +177,14 @@ def on_dag_run_running(self, dag_run: DagRun, msg: str):
if not self.executor:
self.log.error("Executor have not started before `on_dag_run_running`")
return
data_interval_start = dag_run.data_interval_start.isoformat() if dag_run.data_interval_start else None
data_interval_end = dag_run.data_interval_end.isoformat() if dag_run.data_interval_end else None
self.executor.submit(
self.adapter.dag_started,
dag_run=dag_run,
msg=msg,
nominal_start_time=dag_run.data_interval_start.isoformat(),
nominal_end_time=dag_run.data_interval_end.isoformat(),
nominal_start_time=data_interval_start,
nominal_end_time=data_interval_end,
)

@hookimpl
Expand Down