-
Notifications
You must be signed in to change notification settings - Fork 15.1k
Add istio test, use curl /quitquitquit to exit sidecar, and some othe… #33306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But I would love someone elses to take a look as well - who knows better the istio/k8s relations.
@potiuk @eladkal Apology - I just tested locally using breeze with a custom Setting up local airflow env to run KPO with istio enabled isn't so straight forward, so I'll document the steps that I've done here for record also. (FYI I'm using the docker-desktop which comes with k8s cluster and kubectl client)
|
OH... Would be nice to get it into breeze k8s command :) |
Previous 2 PR: #31389, #31390
Refactor the KPO to include istio support. Addressing all the feedback given by others such as:
istio-proxy
is injectedcurl localhost:15020/quitquitquit
to kill the sidecar when istio is enabled, if istio is not enabled it will fallback to using API calldelete_namespaced_pod
OnFinishAction
. Developers can use existing arguments and the operator will check if sidecar is injected, and use different methods to kill the pod depending on whether sidecar is injected or not