Skip to content

Active deadline seconds #31146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Conversation

andyfcx
Copy link

@andyfcx andyfcx commented May 9, 2023

This PR exposes activeDeadlineSeconds in k8s pod spec as a parameter for user's convenience to set for airflow job pods


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@andyfcx andyfcx requested a review from jedcunningham as a code owner May 9, 2023 09:30
@boring-cyborg boring-cyborg bot added provider:cncf-kubernetes Kubernetes (k8s) provider related issues area:providers labels May 9, 2023
@potiuk
Copy link
Member

potiuk commented May 9, 2023

This PR exposes activeDeadlineSeconds in k8s pod spec as a parameter for user's convenience to set for airflow job pods

Can you please update tests for those to include it?

2 similar comments
@potiuk
Copy link
Member

potiuk commented May 9, 2023

This PR exposes activeDeadlineSeconds in k8s pod spec as a parameter for user's convenience to set for airflow job pods

Can you please update tests for those to include it?

@potiuk
Copy link
Member

potiuk commented May 9, 2023

This PR exposes activeDeadlineSeconds in k8s pod spec as a parameter for user's convenience to set for airflow job pods

Can you please update tests for those to include it?

@andyfcx
Copy link
Author

andyfcx commented May 9, 2023

@potiuk Sure, I will work on this in a few days

@andyfcx andyfcx marked this pull request as draft May 9, 2023 15:12
@andyfcx andyfcx force-pushed the active_deadline_seconds branch from 7e8c59c to d4b72de Compare June 6, 2023 07:42
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Jul 22, 2023
@github-actions github-actions bot closed this Jul 28, 2023
@amoghrajesh
Copy link
Contributor

Hi @andyfcx are you still working on this? If not, I would lead it to completion

@andyfcx
Copy link
Author

andyfcx commented Aug 14, 2023

I have been too busy to complete my testing on kubernetes, so it would be great if you can complete it, thanks.

@amoghrajesh
Copy link
Contributor

Thank you for the handover, working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:cncf-kubernetes Kubernetes (k8s) provider related issues stale Stale PRs per the .github/workflows/stale.yml policy file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants