Switch to using vendored-in google ads. #30410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:dev-tools
area:providers
provider:google
eladkal
approved these changes
Apr 1, 2023
potiuk
force-pushed
the
vendored-in-google-ads-no-deps-bump
branch
6 times, most recently
from
e8ba40d to
923626b
Compare
pierrejeambrun
approved these changes
Apr 1, 2023
potiuk
force-pushed
the
vendored-in-google-ads-no-deps-bump
branch
from
923626b to
42aa660
Compare
We are temporarily switching to vendored-in google ads library in order to handle the clash of two issues: * Google ads switching off Google Ads v11 API * Google provider clinging on to old version of google-ads client due to protobuf <4 requirement from other google clients Strategic solution being worked out in apache#30067
potiuk
force-pushed
the
vendored-in-google-ads-no-deps-bump
branch
from
42aa660 to
ef70170
Compare
|
Finally green! |
64 tasks
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are temporarily switching to vendored-in google ads library
in order to handle the clash of two issues:
due to protobuf <4 requirement from other google clients
Strategic solution being worked out in #30067
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.