prohibit adding nonce account to address lookup table #659
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
solana-foundation/solana-improvement-documents#242 will make it impossible to load a nonce account from an address lookup table, so we must adjust the ergonomics of the JS SDK to prohibit creating such a transaction message.
Summary of Changes
createAdvanceNonceAccountInstruction()
produces an AdvanceNonce instruction having anStaticAccount<WritableAccount<TNonceAccountAddress>>
.isAdvanceNonceAccountInstructionForNonce()
to assert that the nonce account in an AdvanceNonce instruction has static set to true.compressTransactionMessageUsingAddressLookupTables()
to refuse to convert any account to a lookup account, if its incompressible property is true.getAccountMetas()
to mark every address in staticAccounts array with propertystatic: true
(discussed here).Fixes #309