faucet: Use PubkeyHasher in the address_cache
#7306
Draft
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadorovsky
force-pushed
the
faucet-pubkey-hasher
branch
from
8933ce9 to
8e15653
Compare
`address_cache` used pubkeys as keys, yet it used the default hasher. To improve performance of lookups, use `PubkeyHasher`.
vadorovsky
force-pushed
the
faucet-pubkey-hasher
branch
from
5bef614 to
2f4faa3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
address_cacheused pubkeys as keys, yet it used the default hasher.Summary of Changes
To improve performance of lookups, use
PubkeyHasher.