Skip to content

AccountsDb::load_account_with takes bool instead of fn #7294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

apfitzge
Copy link

@apfitzge apfitzge commented Aug 4, 2025

Problem

  • should_put_in_read_cache_fn is never a function
    • it is also ALWAYS false outside of our tests, so it's possible we remove the parameter entirely, and just adjust our tests appropriately

Summary of Changes

  • should_put_in_read_cache_fn -> should_put_in_read_cache as simple boolean

@brooksprumo
Copy link

Seems fine to me. Probably worthwhile to find if/when we even inspected the account in the fn version.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.8%. Comparing base (6fbbaf6) to head (92734dd).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #7294     +/-   ##
=========================================
- Coverage    82.8%    82.8%   -0.1%     
=========================================
  Files         801      801             
  Lines      363392   363393      +1     
=========================================
- Hits       300936   300927      -9     
- Misses      62456    62466     +10     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants