Skip to content

Remove - lift_cpi_caller_restriction #6828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Lichtso
Copy link

@Lichtso Lichtso commented Jul 3, 2025

Problem

solana-foundation/solana-improvement-documents#308

Summary of Changes

Removes the feature gate.

Feature Gate Issue: #70

@Lichtso Lichtso requested a review from a team as a code owner July 3, 2025 11:16
.get_mut(1)
.unwrap()
.accounts
.get_mut(6)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the system program from the top-level instruction prevents loader-v3 from CPI calling into it, when the CPI restriction is not lifted.

@Lichtso Lichtso requested a review from 2501babe July 3, 2025 12:38
@LucasSte LucasSte requested a review from buffalojoec July 3, 2025 14:36
Copy link

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the PR title might make other contributors think this feature was activated and then cleaned up. Can we rename it to be something like remove/rescind?

@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2025

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.3%. Comparing base (af62b25) to head (1e032ec).
Report is 49 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #6828     +/-   ##
=========================================
- Coverage    83.3%    83.3%   -0.1%     
=========================================
  Files         853      853             
  Lines      378132   378097     -35     
=========================================
- Hits       315290   315201     -89     
- Misses      62842    62896     +54     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

2501babe
2501babe previously approved these changes Jul 3, 2025
@Lichtso Lichtso changed the title Cleanup - lift_cpi_caller_restriction Remove - lift_cpi_caller_restriction Jul 3, 2025
@Lichtso Lichtso merged commit 5b6880a into anza-xyz:master Jul 9, 2025
41 checks passed
@Lichtso Lichtso deleted the cleanup/lift_cpi_caller_restriction branch July 9, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants