-
Notifications
You must be signed in to change notification settings - Fork 635
Remove - lift_cpi_caller_restriction
#6828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove - lift_cpi_caller_restriction
#6828
Conversation
.get_mut(1) | ||
.unwrap() | ||
.accounts | ||
.get_mut(6) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the system program from the top-level instruction prevents loader-v3 from CPI calling into it, when the CPI restriction is not lifted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the PR title might make other contributors think this feature was activated and then cleaned up. Can we rename it to be something like remove/rescind?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6828 +/- ##
=========================================
- Coverage 83.3% 83.3% -0.1%
=========================================
Files 853 853
Lines 378132 378097 -35
=========================================
- Hits 315290 315201 -89
- Misses 62842 62896 +54 🚀 New features to boost your workflow:
|
lift_cpi_caller_restriction
lift_cpi_caller_restriction
Problem
solana-foundation/solana-improvement-documents#308
Summary of Changes
Removes the feature gate.
Feature Gate Issue: #70