Skip to content

v2.2: Fix - Allow ExtendProgramChecked in CPI (backport of #6245) #6443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jun 6, 2025

Problem

See solana-foundation/solana-improvement-documents#164 (comment).

Feature Gate Issue: https://github.com/anza-xyz/feature-gate-tracker/issues/87

Summary of Changes

Allows invoking loader-v3 ExtendProgramChecked in CPI.
Rekeys the feature enable_extend_program_checked.


This is an automatic backport of pull request #6245 done by Mergify.

@mergify mergify bot added the conflicts label Jun 6, 2025
@mergify mergify bot requested a review from a team as a code owner June 6, 2025 08:38
Copy link
Author

mergify bot commented Jun 6, 2025

Cherry-pick of f5616d3 has failed:

On branch mergify/bp/v2.2/pr-6245
Your branch is up to date with 'origin/v2.2'.

You are currently cherry-picking commit f5616d356.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   Cargo.toml
	modified:   feature-set/src/lib.rs
	modified:   genesis/Cargo.toml
	modified:   programs/bpf_loader/src/syscalls/cpi.rs
	modified:   programs/sbf/Cargo.toml

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   Cargo.lock
	both modified:   programs/sbf/Cargo.lock
	both modified:   svm/examples/Cargo.lock

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot assigned Lichtso Jun 6, 2025
@mergify mergify bot added the conflicts label Jun 6, 2025
Copy link
Author

mergify bot commented Jun 6, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@Lichtso Lichtso removed the conflicts label Jun 6, 2025
@Lichtso Lichtso requested a review from buffalojoec June 6, 2025 08:44
@Lichtso Lichtso force-pushed the mergify/bp/v2.2/pr-6245 branch 2 times, most recently from 71134be to bc49e7f Compare June 6, 2025 08:53
@t-nelson
Copy link

@mergify rebase

* Allows invoking ExtendProgramChecked in CPI.

* Rekeys the feature enable_extend_program_checked.

(cherry picked from commit f5616d3)
Copy link
Author

mergify bot commented Jun 10, 2025

rebase

✅ Branch has been successfully rebased

@t-nelson t-nelson force-pushed the mergify/bp/v2.2/pr-6245 branch from bc49e7f to d2fd13e Compare June 10, 2025 19:35
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 83.4%. Comparing base (4311abc) to head (d2fd13e).
Report is 1 commits behind head on v2.2.

Additional details and impacted files
@@           Coverage Diff            @@
##             v2.2    #6443    +/-   ##
========================================
  Coverage    83.4%    83.4%            
========================================
  Files         807      807            
  Lines      373478   373484     +6     
========================================
+ Hits       311507   311614   +107     
+ Misses      61971    61870   -101     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Lichtso Lichtso merged commit 7f3a6cf into v2.2 Jun 11, 2025
46 checks passed
@Lichtso Lichtso deleted the mergify/bp/v2.2/pr-6245 branch June 11, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants