Skip to content

rpc: fix simulated loaded size tests #6412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025

Conversation

2501babe
Copy link
Member

@2501babe 2501babe commented Jun 4, 2025

Problem

#6063 changed the loaded accounts data size algorithm, and #6023 added loaded size to simulation results, but the latter used the old algorithm in tests

Summary of Changes

use the new algorithm. this fixes ci

Copy link

mergify bot commented Jun 4, 2025

If this PR represents a change to the public RPC API:

  1. Make sure it includes a complementary update to rpc-client/ (example)
  2. Open a follow-up PR to update the JavaScript client @solana/kit (example)

Thank you for keeping the RPC clients in sync with the server API @2501babe.

@2501babe 2501babe self-assigned this Jun 4, 2025
@2501babe 2501babe force-pushed the 20250604_rpcsizetest branch from 05eaad6 to 51570a7 Compare June 4, 2025 15:14
@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2025

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.8%. Comparing base (0c1d60d) to head (51570a7).
Report is 209 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #6412     +/-   ##
=========================================
- Coverage    82.8%    82.8%   -0.1%     
=========================================
  Files         848      848             
  Lines      379050   379513    +463     
=========================================
+ Hits       314021   314294    +273     
- Misses      65029    65219    +190     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@2501babe 2501babe marked this pull request as ready for review June 4, 2025 16:12
@2501babe 2501babe requested a review from a team as a code owner June 4, 2025 16:12
@2501babe 2501babe requested a review from tao-stones June 4, 2025 16:12
@2501babe 2501babe merged commit 994c56a into anza-xyz:master Jun 4, 2025
32 checks passed
@2501babe 2501babe deleted the 20250604_rpcsizetest branch June 4, 2025 18:32
Copy link

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for correcting the tests 🙇🏼‍♂️

mircea-c pushed a commit to mircea-c/agave that referenced this pull request Jun 12, 2025
mircea-c added a commit to mircea-c/agave that referenced this pull request Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants