Skip to content

Feature - Adds LoaderV4Instruction::Copy #4613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Lichtso
Copy link

@Lichtso Lichtso commented Jan 24, 2025

Problem

A new loader-v4 instruction was added to SIMD-0167.

Summary of Changes

Adds:

  • LoaderV4Instruction::Copy
  • is_copy_instruction()
  • copy()
  • test_copy_instruction()
  • process_instruction_copy()
  • test_loader_instruction_copy()

@Lichtso Lichtso requested a review from a team as a code owner January 24, 2025 12:21
Copy link

mergify bot commented Jan 24, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@Lichtso Lichtso force-pushed the feature/add_loader_v4_copy_instruction branch 2 times, most recently from 7b8d445 to 6fce479 Compare January 24, 2025 12:53
LucasSte
LucasSte previously approved these changes Jan 24, 2025
@Lichtso Lichtso force-pushed the feature/add_loader_v4_copy_instruction branch from 6fce479 to f4c5052 Compare January 24, 2025 17:11
@Lichtso Lichtso force-pushed the feature/add_loader_v4_copy_instruction branch from f4c5052 to c0724bb Compare January 24, 2025 17:15
@Lichtso Lichtso merged commit d12cfde into anza-xyz:master Jan 24, 2025
59 checks passed
@Lichtso Lichtso deleted the feature/add_loader_v4_copy_instruction branch January 24, 2025 18:31
@Lichtso Lichtso added the feature-gate Pull Request adds or modifies a runtime feature gate label Apr 24, 2025
Copy link

mergify bot commented Apr 24, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-gate Pull Request adds or modifies a runtime feature gate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants