Implement SAML 2.0 protocol support

[adalinesimonian]

No description provided.

[christiansmith]

#137

[adalinesimonian]

Whether or not we wait for node-saml/passport-saml#113 largely depends on whether or not multiple AttributeStatements generally exist in SAML 2.0 responses for the majority of our users who intend to use SAML.

[christiansmith]

@vsimonian I think we should probably go ahead and merge this and release, then update when the passport-saml update is released. But first, I want to shake it down with my local setup. Mind doing a walkthrough on the setup + code review? I can make time later today or some time tomorrow.

[christiansmith]

@vsimonian can you explain what providerInfo, providerNames, and visibleProviders is all about?

https://github.com/anvilresearch/connect/pull/245/files#diff-6d4018922cfaa7ff5385670907dccb09R18

[christiansmith]

Also, are you able to resolve the conflicts on your end? Now that node-saml/passport-saml#113 is merged, I want go ahead and merge/release this...

[adalinesimonian]

providerInfo, providerNames, and visibleProviders are different locals expected by the sign-in view, that were missing from this code, thus breaking the sign-in view rendering when it went down this code path. Elsewhere, they already exist. providerInfo is the provider definition information keyed by provider ID, providerNames is a list of provider IDs, and visibleProviders contains only providers not marked as hidden.

Hopefully conflicts should be resolved by now.

[christiansmith]

@vsimonian good catch on the missing state. What's the purpose of hidden providers? This must be something you added when working on LDAP/AD, etc? I don't recall writing that code...

[adalinesimonian]

Hidden providers was implemented for the CLI, allowing the password provider to be always enabled but not visible to allow authority users to continue to sign in for server administration.

[christiansmith]

Know of a SAML service that's easy to integrate with for testing before I merge?

[adalinesimonian]

http://stubidp.kentor.se should be the easiest to work with; you have complete control over the entire set of SAML claims that gets returned.

[christiansmith]

@vsimonian mind writing up documentation for using this in a PR on connect-docs?

[christiansmith]

Verified. Still needs docs.