feat: json schema valid for mind-map, network... #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hustcc
reviewed
Jun 6, 2025
| @@ -12,7 +12,6 @@ import { | |||
| startStdioMcpServer, | |||
| } from "./services"; | |||
| import { ChartTypeMapping, generateChartUrl } from "./utils"; | |||
|
|
|||
hustcc
reviewed
Jun 6, 2025
| @@ -77,7 +77,17 @@ function setupToolHandlers(server: Server): void { | |||
| } | |||
| } | |||
|
|
|||
| const url = await generateChartUrl(chartType, args); | |||
| const res = await generateChartUrl(chartType, args); | |||
There was a problem hiding this comment.
这里的改法，应该是在 generateChartUrl 方法中 throw error 会被这个大的 try catch 到。然后返回值还是保持返回 url，
hustcc
reviewed
Jun 6, 2025
| @@ -29,5 +33,5 @@ export async function generateChartUrl( | |||
| }, | |||
| ); | |||
|
|
|||
| return response.data.resultObj; | |||
| return response.data; | |||
There was a problem hiding this comment.
这个方法加判断 success = 0 的情况，然后 throw new Error('xxxx')
hustcc
reviewed
Jun 6, 2025
| width: WidthSchema, | ||
| height: HeightSchema, | ||
| }) | ||
| .refine((data) => validatedFlowNetWorkSchema(data), { |
hustcc
reviewed
Jun 6, 2025
| * @param data | ||
| * @returns boolean | ||
| */ | ||
| export const validatedFlowNetWorkSchema = (data: FlowAndNetWorkOption) => { |
There was a problem hiding this comment.
校验 data 即可，然后数据分成为两类，以内是 TreeData，一类的 NodeEdgeData。这么看，也需要看看矩阵树图的校验。
hustcc
reviewed
Jun 6, 2025
| height: number; | ||
| } | ||
| /** | ||
| * validatedFlowNetWorkSchema |
hustcc
reviewed
Jun 6, 2025
| const nodeNames = new Set(data.data.nodes.map((node) => node.name)); | ||
| const errors: string[] = []; | ||
|
|
||
| const uniqueNodeNames = new Set(); |
There was a problem hiding this comment.
发现一个错误就跳过，不用发现所有的错误，这样逻辑简单一些。error message 一定需要模型能理解和修正。
hustcc
reviewed
Jun 6, 2025
| `Invalid parameters: ${errors.join("")}`, | ||
| ); | ||
| } | ||
| return !(errors.length > 0); |
hustcc
reviewed
Jun 6, 2025
| @@ -0,0 +1,97 @@ | |||
| import { ErrorCode, McpError } from "@modelcontextprotocol/sdk/types.js"; | |||
|
检测一下 treemap 是否也需要检测？另外增加一些校验不通过的规则的单测。 |
|
错误前缀有重复。 |
hustcc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
入参校验结果
思维导图：
流程图：
