Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(base): rawFields 添加回调，对 geometry color shape 进行了区分 #3288

Merged
merged 2 commits into from
Jul 28, 2022
Merged

fix(base): rawFields 添加回调，对 geometry color shape 进行了区分 #3288

merged 2 commits into from
Jul 28, 2022

Conversation

ai-qing-hai
Copy link
Contributor

@ai-qing-hai ai-qing-hai commented Jul 19, 2022 •
edited
Loading

-[x] rawFields 添加回调，对 geometry color shape 进行了区分 (和 G2 一样进行了区分)

Before After
原先 rawFields 对 line 和 point 等统一加的分组 回调后可以对 line 和 point 等进行区分分组
原先 rawFields 对 color 和 shape 等统一加的分组 回调后可以对 color 和 shape 等进行区分分组

可以对 point 区分 并且不改变 line 的分组
image

fixed #3287

@ai-qing-hai ai-qing-hai requested a review from visiky July 19, 2022 11:41
@github-actions github-actions bot added bugfix and removed bugfix labels Jul 19, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2022 •
edited
Loading

🎊 PR Preview 5b17368 has been successfully built and deployed to https://antvis-G2Plot-preview-pr-3288.surge.sh?type=diff&date=2022-07-19

🕐 Build time: 81.1s

🤖 By Surge Ui Insight

@visiky visiky merged commit da3d1a6 into master Jul 28, 2022
@visiky visiky deleted the fix-base-rawFields branch July 28, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visiky visiky Awaiting requested review from visiky

Assignees
No one assigned
Labels
bugfix PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 [BUG]g2plot 折线图 point.shape 回调参数不完整
2 participants
@ai-qing-hai @visiky