fix(heatmap): 添加 meta 中的最大最小值参数 可以控制最小显示参数 #3272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 PR Preview 22c132c has been successfully built and deployed to https://antvis-G2Plot-preview-pr-3272.surge.sh?type=diff&date=2022-07-11 🕐 Build time: 73.716s
🤖 By Surge Ui Insight |
hustcc
reviewed
Jul 11, 2022
src/plots/heatmap/adaptor.ts
Outdated
| const max = Math.max(...field); | ||
| let { min, max } = meta?.[sizeField] || {}; | ||
| min = min || Math.min(...field); | ||
| max = max || Math.max(...field); |
|
单测中似乎有 lint 错误。 |
|
@hustcc 少了个换行， 已经加上了 |
visiky
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #3170