fix(dualaxes): configure legend selected #2784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shamann
changed the title
ai-qing-hai
reviewed
Aug 11, 2021
| if (geometryOptions[1].seriesField) { | ||
| rightView.legend(geometryOptions[1].seriesField, legend); | ||
| } | ||
|
|
There was a problem hiding this comment.
src\plots\dual-axes\util\legend.ts
加到这里也可以，就不用判断了。
|
@visiky 我这边看着应该没什么问题，看测试用例也都跑通了 |
|
不过补充一点，在双轴图图例里很麻烦的一点是将左右view没有拆分字段的，和左右view中有拆分字段的行为统一起来。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR includes
Screenshot