Skip to content

fix: 修复散点图 size 回调不生效 #2263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 26, 2021
Merged

fix: 修复散点图 size 回调不生效 #2263

merged 3 commits into from
Jan 26, 2021

Conversation

lxfu1
Copy link
Member

@lxfu1 lxfu1 commented Jan 25, 2021

PR includes

  • fixed #0
  • add / modify test cases

Screenshot

Before After

@github-actions
Copy link
Contributor

github-actions bot commented Jan 25, 2021 •
edited
Loading

😭 Deploy PR Preview b14fe7d failed. Build logs

🤖 By surge-preview

@coveralls
Copy link

coveralls commented Jan 25, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 508866868

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 96.723%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/plots/scatter/adaptor.ts 3 4 75.0%
Totals Coverage Status
Change from base Build 506888881: -0.03%
Covered Lines: 4640
Relevant Lines: 4683
💛 - Coveralls

@visiky visiky merged commit 510c1b5 into master Jan 26, 2021
@visiky visiky deleted the fix/scatter-size branch January 26, 2021 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visiky visiky visiky left review comments

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lxfu1 @coveralls @visiky