Skip to content

feat: 增加交互 #2219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 26, 2021
Merged

feat: 增加交互 #2219

merged 10 commits into from
Jan 26, 2021

Conversation

liuzhenying
Copy link
Member

@liuzhenying liuzhenying commented Jan 14, 2021

矩形树图拟计划提供三种交互

  • 下钻:效果见下图
  • 放大:直接使用 view-zoom 即可
  • drag-move: 移动 散点图的 drag-move 到公共目录

PR includes

  • add / modify test cases
  • documents, demos

Screenshot

Before After
treemap-drill-interaction
为矩形树图提供下钻交互

@github-actions
Copy link
Contributor

github-actions bot commented Jan 14, 2021

😭 Deploy PR Preview 7888536 failed. Build logs

🤖 By surge-preview

@coveralls
Copy link

coveralls commented Jan 14, 2021

Pull Request Test Coverage Report for Build 512064471

  • 84 of 88 (95.45%) changed or added relevant lines in 6 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.04%) to 96.68%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/plots/treemap/interactions/treemap-drill-down.ts 6 7 85.71%
src/plots/treemap/interactions/util.ts 12 13 92.31%
src/plots/treemap/interactions/actions/treemap-drill-down-action.ts 29 31 93.55%
Files with Coverage Reduction New Missed Lines %
src/plots/pie/adaptor.ts 1 94.02%
src/plots/waterfall/adaptor.ts 1 95.74%
Totals Coverage Status
Change from base Build 510934906: -0.04%
Covered Lines: 4718
Relevant Lines: 4765

💛 - Coveralls

@lgtm-com
Copy link

lgtm-com bot commented Jan 26, 2021

This pull request introduces 1 alert when merging 27d9b84 into 510c1b5 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Jan 26, 2021

This pull request introduces 1 alert when merging 0912978 into 6787c8b - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Jan 26, 2021

This pull request introduces 1 alert when merging f44020d into 6787c8b - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@liuzhenying liuzhenying changed the title [WIP] feat: 增加交互 feat: 增加交互 Jan 26, 2021
@hustcc hustcc self-requested a review January 26, 2021 12:16
@hustcc
Copy link
Member

hustcc commented Jan 26, 2021

@liuzhenying 覆盖率稍有降低~我先合并,后面在处理

@hustcc hustcc merged commit 9f206e3 into master Jan 26, 2021
@hustcc hustcc deleted the feat/treemap-zoom branch January 26, 2021 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants