Skip to content

Feat pie #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 14, 2020
Merged

Feat pie #1290

merged 5 commits into from
Jul 14, 2020

Conversation

visiky
Copy link
Member

@visiky visiky commented Jul 14, 2020

  • scripts: test-live 增加 watch 参数
  • feat: 抽取通用 adaptor 构建器,tooltip (便于后续 tooltip 统一 优化展示,现在太丑了)
  • 饼图 plot 初版
    • feat: angleField、colorField、legend、tooltip、pieStyle
    • testcase

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@hustcc hustcc self-requested a review July 14, 2020 13:31
@hustcc hustcc merged commit f7b68f8 into v2 Jul 14, 2020
@hustcc hustcc deleted the feat-pie branch July 14, 2020 13:32
@lgtm-com
Copy link

lgtm-com bot commented Jul 14, 2020

This pull request introduces 1 alert when merging 99075c8 into d89ecf6 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@hustcc hustcc added the v2 label Jul 15, 2020
@hustcc hustcc added this to the v2 milestone Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants