fix: re-adds retry in e2e kind setup #7120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
petertran-avgo
commented
Apr 11, 2025
petertran-avgo
commented
- PR fix: batch probing in e2e test setup (#7067) #7068 removed the 10 retries for setting up the cluster which introduced flakiness in CI
Dyanngg
reviewed
Apr 11, 2025
| if httpServerReadiness.isReady() { | ||
| log.Infof("All HTTP servers are ready") | ||
| return nil | ||
| } |
There was a problem hiding this comment.
maybe we should add back the time.Sleep(defaultInterval) in the original PR? I don't feel like this is gonna slow down the average CI run
There was a problem hiding this comment.
Thank you! Re-added the timeout in my recent push
* PR antrea-io#7068 removed the 10 retries for setting up the cluster which introduced flakiness in CI Signed-off-by: Peter Tran <[email protected]>
petertran-avgo
force-pushed
the
fix-re-add-retries
branch
from
06b3b9e to
b8792c4
Compare
antoninbas
approved these changes
Apr 11, 2025
|
/test-e2e |
1 similar comment
|
/test-e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.