Mark libarchive as required so CMake errors out if not found #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you mind tagging this change so I can update the conan package to support 2.2.x with no patches? Otherwise I'd have to include this as a patch |
|
Sure, there is still a PR left which will not take a long time to get merged, once that's merged, I will make a new release. |
|
Awesome, thanks. |
|
Kind reminder :) |
|
v2.2.2 with your fixes and other refactors: https://github.com/antony-jr/QArchive/releases/tag/v2.2.2 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your Pull Request:
libarchive is not an optional dependency so it must be marked as such. This ensures cmake errors out on
find_packageinstead of further down the line while trying to link.