feat: enable auto-install to be used in all commands (not only nci)
#277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… options (prioritising input over environment)
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What:
Add a way to turn on
autoInstallfor all commands.This is a non breaking change that enable users to do something like this.
It should work in all commands, but I need this feature specifically in
nr(to runnrin CI without installing the package manager, as I don't know which one will be used)How:
A new "module" to detect environment variables are added and used in the runner.
The runner now merges the options provided as input with the environment options prioritising the provided input.
I added a little bit of tests also for the runner file, It's not currently testing everything, but considering that there were no test prior to this, it's a starting point.
Linked Issues
fix #247
Additional context
I'm not particularly a fan of the test I added as I'm leveraging the mock of
detectto see what options are being passed down.