Upgrade tslint #1051
Merged
Upgrade tslint #1051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@afc163, thanks for your PR! By analyzing the history of the files in this pull request, we identified @silentcloud, @liqi07 and @warmhug to be potential reviewers. |
paranoidjk
force-pushed
the
upgrade-tslint
branch
from
cca29df to
5718d57
Compare
Codecov Report
@@ Coverage Diff @@
## master #1051 +/- ##
==========================================
- Coverage 70.06% 70.06% -0.01%
==========================================
Files 215 215
Lines 3979 3978 -1
Branches 1189 1188 -1
==========================================
- Hits 2788 2787 -1
Misses 1189 1189
Partials 2 2
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1051 +/- ##
==========================================
+ Coverage 69.79% 69.84% +0.05%
==========================================
Files 218 218
Lines 4062 4079 +17
Branches 1212 1212
==========================================
+ Hits 2835 2849 +14
- Misses 1226 1229 +3
Partials 1 1
Continue to review full report at Codecov.
|
|
这个改动尽快合并吧？不然冲突很多 |
paranoidjk
force-pushed
the
upgrade-tslint
branch
from
5718d57 to
1586a45
Compare
|
这个我这周末处理掉。 |
|
wait for palantir/tslint-react#79 |
paranoidjk
force-pushed
the
upgrade-tslint
branch
from
1586a45 to
c842ceb
Compare
|
TypeScript is not 100% works fine with React. |
paranoidjk
force-pushed
the
upgrade-tslint
branch
2 times, most recently
from
219d83a to
4bb5618
Compare
|
诶，本地是过的为啥ci挂了.... |
paranoidjk
force-pushed
the
upgrade-tslint
branch
from
4bb5618 to
fa9579a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Someboy come and finish the last task.