Skip to content

Remove requirements file and add dependencies in toml file #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 21, 2022
Merged

Remove requirements file and add dependencies in toml file #74

merged 5 commits into from
Nov 21, 2022

Conversation

Revathyvenugopal162
Copy link
Collaborator

@Revathyvenugopal162 Revathyvenugopal162 commented Nov 21, 2022 •
edited
Loading

  • Remove requirements files as dependabot will find the toml files for update
  • Update the precommit hooks
  • Modify workflow

@github-actions github-actions bot added dependencies Related with project dependencies maintenance Package and maintenance related CI/CD enhancement New features or code improvements labels Nov 21, 2022
@Revathyvenugopal162 Revathyvenugopal162 marked this pull request as ready for review November 21, 2022 12:16
echambla
echambla reviewed Nov 21, 2022
View reviewed changes
@github-actions github-actions bot removed the CI/CD label Nov 21, 2022
@github-actions github-actions bot added the CI/CD label Nov 21, 2022
echambla
echambla approved these changes Nov 21, 2022
View reviewed changes
Copy link
Collaborator

@echambla echambla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of having dependabot looking directly at toml file and get rid of requirements duplication!

MaxJPRey
MaxJPRey approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Revathyvenugopal162 Revathyvenugopal162 merged commit 8040a5c into main Nov 21, 2022
@Revathyvenugopal162 Revathyvenugopal162 deleted the feat/take-requirements-files branch November 21, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxJPRey MaxJPRey MaxJPRey approved these changes

@echambla echambla echambla approved these changes

Assignees
No one assigned
Labels
dependencies Related with project dependencies enhancement New features or code improvements maintenance Package and maintenance related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Revathyvenugopal162 @MaxJPRey @echambla